Feature update angles computation #30
Conversation
Moved all computations to gac_reader and simplified. Note that sun azimuth was before +=180 and satellite azimuth was before -=180. The rel_azi written to hdf file should be the same as before.
Moved the absolute azimuth angle difference computation to pygac/__init__.py. Also included unit test of this function.
There was a problem hiding this comment.
This looks good to me, I just have some change request concerning the fancy indexing.
Also, regarding coding style, please install flake8 with the plugins flake8-docstrings, flake8-debugger, flake8-bugbear and run something like
git diff origin/master -- "*py" | flake8 --diff
to fix the styling issues.
|
Regarding np.where, I am avoiding it because it makes a copy of the array. And the indexing only updates the elements in question. |
|
Note that this PR changed the azimuth angles. From documentation (that was updated in PR35). Pygac was updated to use the same definition for angles as pyorbital (20190926, version 1.1.0). Previous versions used azimuth +/-180 degrees, which correspond to degrees clockwise from south. All angles are converted to degrees. |
The PR will correct the (rel_azi) absolute azimuth difference angle that is retrieved from gac_reader.
Currently 180 minus rel_azi is retrieved from the reader and it is corrected again back to rel_azi in gac_io before writing.