-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor I/O #31
Merged
Merged
Refactor I/O #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move non-I/O parts from gac_io to the readers to make them available in satpy.
- Adapt VIS threshold to new reflectance range (0, 100) - Fix channel selection (is specific to POD/KLM)
To prevent pulling in h5py as extra dependency in satpy.
Repeatedly stripping invalid lats for each channel affects performance.
Scanline range specified by the user is *after* stripping scanlines with invalid coordinates.
5 tasks
mraspaud
requested changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comprehensive refactor and adding all the tests! Just a few small points to fix.
This reverts commit 2345910.
- Lat/lon interpolation - Clock drift adjustment
Otherwise importing gac_io without PYGAC_CONFIG_FILE set would fail.
mraspaud
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move masking/correction logic from
gac_io
to the readers so that the satpy reader (which is using pygac as a library) returns the same data aspygac-run
writes to hdf5.The refactoring doesn't change the output expect for one case:
Other features added:
PYGAC_CONFIG_FILE
required for use in satpy)The changes have been validated with 130 "best of corruption" orbits. Summary:
You can find some plots here: https://public.cmsaf.dwd.de/data/sfinkens/pygac_refactoring/ . Display them in 100%. You might have to clean your screen in order to see the mask difference in some cases ;)
TODO: