Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of missing scanlines #36

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

sfinkens
Copy link
Member

If selecting user-defined scanlines or stripping scanlines with invalid coordinates, the list of missing scanlines is updated using pygac.utils._update_missing_scanlines. But under certain circumstances (e.g. calling that method twice), the updated list would contain duplicates. That is fixed by this PR.

Prevent lines from being added twice.
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch !

@mraspaud mraspaud merged commit ba2f2dc into pytroll:master Oct 25, 2019
@mraspaud mraspaud added the bug label Oct 25, 2019
@mraspaud mraspaud added this to the v1.2.1 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants