Add meta_data dictionary to reader class. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now save only sun_earth_distance_correction. Calculate the sun_earth_distance_correction_factor only once.
sfinkens
requested changes
Nov 25, 2019
|
LGTM |
sfinkens
approved these changes
Nov 25, 2019
sfinkens
requested changes
Nov 26, 2019
sfinkens
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the sun_earth_distance_correction_factor only once.
Add it to meta_data dictionary in reader class.
For now meta_data contain only sun_earth_distance_correction_factor.
But the idea (Martin's) is that updating some attributes in pygac in
the future should not always require a PR to satpy.
PR will solve issue #40.