Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #42

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Update documentation #42

merged 5 commits into from
Dec 4, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens marked this pull request as ready for review November 27, 2019 10:34
@sfinkens sfinkens self-assigned this Nov 27, 2019
ninahakansson
ninahakansson reviewed Nov 27, 2019
View reviewed changes
pygac/gac_reader.py
@@ -460,14 +460,18 @@ def get_angles(self):
and different ranges.

Returns:
sat_azi: satellite azimuth angle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice. Does it still follow google-style doc strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. No it doesn't. I've changed it according to https://stackoverflow.com/a/29343326/5703449.

ninahakansson
ninahakansson approved these changes Nov 27, 2019
View reviewed changes
Copy link
Collaborator

@ninahakansson ninahakansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mraspaud
mraspaud approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 559c1bc into pytroll:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninahakansson ninahakansson ninahakansson approved these changes

@mraspaud mraspaud mraspaud approved these changes

Assignees

@sfinkens sfinkens

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfinkens @mraspaud @ninahakansson