-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LAC support #45
Add LAC support #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I didn't go through all the details, just two questions:
- The KLM readers don't have a
scan_points
attribute, is that correct? - For POD, the
scan_points
array only has 408 elements, is that correct? - That said, it would be nice if you could explain the meaning of
scan_points
andoffset
in the reader docstring :)
Good points, I'll check these |
'noaa9': {'roll': 0.000, | ||
'pitch': 0.0025, | ||
'yaw': 0.000, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfinkens could this be a problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's the reason!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now we just have to decide if it's making the data better or not, right ? or should I just remove this ?
More thorough comparison needs to be done on this
np.arange(3.5, 2048, 5).shape
(409,) ? |
Sorry about the 408, I printed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System tests pass 👍
This PR adds support for LAC reading.
Hopefully it keeps the GAC reading untouched.
This supersedes and closes #5