Fix tests on bigendian platforms #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalentino
changed the title
|
Nice catch @avalentino ! Looks good to me, but since I'm not so familiar with endianness, I'd like to request a review from @mraspaud or @carloshorn 🙂 |
mraspaud
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure on Bug Endian platforms that we discovered building the debian package for pygac (see [1]).
The issue seems to be in the test code, not in the library.
[1] https://buildd.debian.org/status/fetch.php?pkg=pygac&arch=s390x&ver=1.4.0-1&stamp=1596978522&raw=0
The PR is marked as WIP because the fix is till under test. We will give an acknowledgement once the test completes
Edit:
Tests on s390x completed successfully.