-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VII interpolator. #22
Conversation
Many lint errors come from the
if white spaces are removed, readability is compromised. |
Either add |
i removed the spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice work! This is just a first review, since I need more information on how the interpolation scheme goes to be able to review the algorithmic par of this.
Also, could you add a page in the documentation for this module ?
I have raised an issue on this. Link to the documentation should be added once publicly available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one thing to fix!
Add VII interpolator. A first prototype interpolation is provided and it's purpose is to navigate the simulated test data which most likely still has some things to be ironed out. The code may have to be revisited later on.
git diff origin/master **/*py | flake8 --diff