Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NWCSAF-GEO composites for ABI, AHI, FCI #1136

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gerritholl
Copy link
Member

@gerritholl gerritholl commented Apr 7, 2020

Currently the NWCSAF-GEO composites only for for SEVIRI. This PR
enables them for the other geostationary imagers supported by NWCSAF-GEO
as well: ABI, AHI, and FCI.

Currently the NWCSAF-GEO composites only for for SEVIRI.  This commit
enables them for the other geostationary imagers supported by NWCSAF-GEO
as well: ABI, AHI, and FCI.
@ghost
Copy link

ghost commented Apr 7, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.001 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@gerritholl
Copy link
Member Author

Currently this PR copy-pastes the YAML code from the seviri.yaml file to each of abi.yaml, ahi.yabl, and fci.yaml. This is a hard to maintain solution that violates Don't Repeat Yourself (DRY). I don't know how I can avoid that, seeing that YAML apparently does not support includes and that visir.yaml already contains composites with the same names but expecting nwcsaf-pps data. Pending a solution to that I've put this PR in draft mode. It works, it passes tests, but it's not a good solution yet.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 89.605% when pulling 68e99a4 on gerritholl:enable-nwcsaf-other-geo into 446af3a on pytroll:master.

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1136 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   89.60%   89.60%   -0.01%     
==========================================
  Files         200      200              
  Lines       29484    29484              
==========================================
- Hits        26420    26419       -1     
- Misses       3064     3065       +1     
Impacted Files Coverage Δ
satpy/scene.py 90.01% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce07c0...68e99a4. Read the comment docs.

@gerritholl
Copy link
Member Author

@pytroll/core This PR currently duplicates YAML code between seviri.yaml, abi.yaml, ahi.yaml, and fci.yaml (I dislike that, therefore it's still a draft). How can I adapt it to avoid this duplication, considering that visir.yaml is already occupied by nwcsaf-pps-based composites of the same name (but with differently named prerequisites)?

@djhoese
Copy link
Member

djhoese commented Apr 8, 2020

From what I see we have four choices:

  1. What you're doing now.
  2. Move them to visir.yaml
  3. Refactor the composite loading to load all/most YAMLs (similar to what's been discussed in the various plugin issues/PRs). We could then make a YAML for nwcsaf-specific composites.
  4. Create a separate package that includes these configs similar to fogpy.

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 20, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 20, 2024

The testing process was executed successfully. See the test results for this pull request here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make nwcsaf-geo composites available to other geostationary imagers besides SEVIRI
4 participants