A small change in start_time, end_time reading through datatime. #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start_time, end_time issues
Update scatsat1_l2b.py
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 89.61% 90.30% +0.68%
==========================================
Files 200 239 +39
Lines 29522 34236 +4714
==========================================
+ Hits 26457 30916 +4459
- Misses 3065 3320 +255
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mraspaud
requested changes
May 6, 2020
lma flash extend 2d
stickler-ci
reviewed
Dec 1, 2020
| @@ -31,8 +31,8 @@ def __init__(self, filename, filename_info, filetype_info): | |||
| self.h5f = h5py.File(self.filename, "r") | |||
| h5data = self.h5f['science_data'] | |||
|
|
|||
| self.filename_info['start_time'] = datetime.strptime(h5data.attrs['Range Beginning Date'], '%Y-%jT%H:%M:%S.%f') | |||
| self.filename_info['end_time'] = datetime.strptime(h5data.attrs['Range Ending Date'], '%Y-%jT%H:%M:%S.%f') | |||
| self.filename_info['start_time'] = datetime.strptime(h5data.attrs['Range Beginning Date'].decode('ascii'), '%Y-%jT%H:%M:%S.%f') | |||
There was a problem hiding this comment.
E501 line too long (135 > 120 characters)
| self.filename_info['start_time'] = datetime.strptime(h5data.attrs['Range Beginning Date'], '%Y-%jT%H:%M:%S.%f') | ||
| self.filename_info['end_time'] = datetime.strptime(h5data.attrs['Range Ending Date'], '%Y-%jT%H:%M:%S.%f') | ||
| self.filename_info['start_time'] = datetime.strptime(h5data.attrs['Range Beginning Date'].decode('ascii'), '%Y-%jT%H:%M:%S.%f') | ||
| self.filename_info['end_time'] = datetime.strptime(h5data.attrs['Range Ending Date'].decode('ascii'), '%Y-%jT%H:%M:%S.%f') |
There was a problem hiding this comment.
E501 line too long (130 > 120 characters)
DeepCode's analysis on #6c0d8a found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
check for lma |
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 satpyAUTHORS.mdif not there already