Fix DNB enhancement compositors #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
stickler-ci
reviewed
Apr 16, 2018
| (-20037508.34, -10018754.17, 20037508.34, 10018754.17)) | ||
|
|
||
| comp = ERFDNB('dynamic_dnb', prerequisites=('dnb',), | ||
| standard_name='toa_outgoing_radiance_per_' |
There was a problem hiding this comment.
E127 continuation line over-indented for visual indent
Codecov Report
@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
+ Coverage 61.24% 63.89% +2.65%
===========================================
Files 111 112 +1
Lines 13711 13858 +147
===========================================
+ Hits 8397 8855 +458
+ Misses 5314 5003 -311
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert VIIRS DNB compositors to work with xarray and dask. This PR takes the easy road for some of them by running
delayed(func)thenda.from_delayed. These algorithms/enhancements aren't vectorized so they aren't simple to completely dask-ify. They also involve histogram calculations which make dask-ifying not super useful unless done really really well.Note the VIIRS true color (or anything using the ratio sharpening from the viirs_sdr reader) fails currently due to a bug in XArray or what I consider a bug (pydata/xarray#2060). My
viirs_sdrreader assigns a "coordinates" attribute to the datasets with either[m_longitude, m_latitude]or[i_longitude, i_latitude]. Due to the bug this raises an exception when datasets are concatenated together.git diff origin/develop **/*py | flake8 --diff