Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dask for rtd builds #3040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jan 22, 2025

This PR fixes the rtd builds by pinning the dask version.

This pinning, along with the ones done for CI (#3035), will need to be removed when holoviews is fixed to use dask >= 2025.1

@mraspaud mraspaud self-assigned this Jan 22, 2025
@mraspaud mraspaud requested a review from djhoese as a code owner January 22, 2025 10:45
@mraspaud
Copy link
Member Author

According to holoviz/datashader#1390 the upstream fix will be released this week. Is it worth merging this?

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (38d106d) to head (75bc5bf).
Report is 55 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3040    +/-   ##
========================================
  Coverage   96.10%   96.11%            
========================================
  Files         381      383     +2     
  Lines       55544    55673   +129     
========================================
+ Hits        53383    53511   +128     
- Misses       2161     2162     +1     
Flag Coverage Δ
behaviourtests 3.89% <ø> (-0.01%) ⬇️
unittests 96.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12906523105

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.222%

Totals Coverage Status
Change from base Build 12905542942: 0.0%
Covered Lines: 53758
Relevant Lines: 55869

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants