-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image 'mode' as identifying attribute to enhancements #817
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
+ Coverage 83.72% 83.75% +0.02%
==========================================
Files 165 165
Lines 24115 24167 +52
==========================================
+ Hits 20190 20240 +50
- Misses 3925 3927 +2
Continue to review full report at Codecov.
|
@djhoese What is the status of this PR? Is this still current? Seems to have some merge conflicts. |
@gerritholl I still like the idea of this PR but I think @pnuu and @mraspaud didn't like it so much. I can fix the conflicts, but am curious what their current opinion is. |
Similar to how we have
name
andstandard_name
as identifying factors that someone can use in the enhancement configs, this PR addsmode
. This is used in the new RGB default enhancement which does a crude linear stretch between 0 and 1. This is a nice thing to have when creating new RGBs and experimenting with them because we don't have to configure a new enhancement every time. This is also useful for DayNightCompositor composites which are already enhanced and on a 0 to 1 scale. This way you could make any number of DayNight composites and wouldn't need to make a new 0 to 1 enhancement for each one.I should really add documentation for this and it needs tests but I wanted to have people look at this as soon as possible since I'd like this for my scipy tutorial.
The other thing that is not implemented here but has been talked about is the shortcut of allowing certain attributes to "shortcut" the enhancement process. So if an RGB is detected (via the enhancement mode) then a special RGB-friendly enhancement would be used which would default to color limits of 0 and 1 for each band but could also use a
color_limits
attribute orvmin
andvmax
attributes if they existed to override the 0 and 1. I'm not sure this is the right time to implement this functionality since it seems like a work around for the general problem of "creating enhancements is more annoying than it should be for simple composites".flake8 satpy