Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove longitude/latitude 2D xarray coordinates #841

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 2, 2019

This was discovered while testing #836. Xarray currently has a bug (of sorts) where any dask array coordinates are computed whenever two xarray DataArrays are combined. See the related xarray issue. Until this is resolved better on the xarray/dask side we need to stop adding these coordinates.

As is, this requires a lot of computation to load/compute these geolocation arrays.

  • Tests added and test suite added to parent suite
  • Tests passed
  • Passes flake8 satpy

@djhoese
Copy link
Member Author

djhoese commented Jul 2, 2019

This also includes small changes to the Filler compositor to check areas before trying to operate on the data. And a change to yaml_reader.py so that the name of a SwathDefinition is only set once.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I thought I had questions on this, but on closer inspection it looks clear to me.

@mraspaud
Copy link
Member

mraspaud commented Jul 2, 2019

One question: am I understanding correctly that the coords are still there in case of a swath ?

@djhoese
Copy link
Member Author

djhoese commented Jul 2, 2019

@mraspaud Which coords? In the case of a SwathDefinition based DataArray there will be no coordinates with this PR. Without this PR and pyproj 2.0+ installed you would get longitude and latitude, without this PR and pyproj <2.0 you would not get any coordinates.

@mraspaud
Copy link
Member

mraspaud commented Jul 2, 2019

ok, good

@coveralls
Copy link

coveralls commented Jul 2, 2019

Coverage Status

Coverage decreased (-0.0005%) to 83.983% when pulling 714fb21 on djhoese:bugfix-lonlat-coords into 44239a0 on pytroll:master.

@djhoese djhoese merged commit 7d6abe9 into pytroll:master Jul 2, 2019
@djhoese djhoese deleted the bugfix-lonlat-coords branch July 2, 2019 18:29
@djhoese
Copy link
Member Author

djhoese commented Jul 2, 2019

As noted on slack, the OSX tests were failing because conda was hanging for some reason. For now I'm going to assume that this is a known issue with conda or ci-helpers and will continue focusing on making a patch release in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants