Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.4 #82

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Release 0.6.4 #82

merged 1 commit into from
Nov 8, 2024

Conversation

jakub-safetycli
Copy link
Contributor

@jakub-safetycli jakub-safetycli commented Oct 18, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): Version bump

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Transitioned the project "dparse" from a beta release to a stable release with version update to 0.6.4.
  • Bug Fixes

    • Improved formatting for Python 3.12 entry in the classifiers section.
  • Chores

    • Updated CI workflow to simplify the Python version matrix by excluding version 3.7.
    • Added Git user details configuration for the testing job.

@jakub-safetycli jakub-safetycli requested a review from a team as a code owner October 18, 2024 18:45
Copy link

coderabbitai bot commented Oct 18, 2024

Walkthrough

The changes involve an update to the pyproject.toml file for the "dparse" project, where the version number has been changed from "0.6.4b0" to "0.6.4," indicating a transition from beta to stable release. The classifiers section has been reformatted to remove trailing whitespace for the Python 3.12 entry. Additionally, the CI workflow configuration has been updated to exclude Python version "3.7" from the testing matrix, retaining versions "3.8," "3.9," "3.10," "3.11," "3.12," and "3.13." A new step for Git user configuration has also been added.

Changes

File Change Summary
pyproject.toml Updated version from "0.6.4b0" to "0.6.4"; reformatted Python 3.12 classifier entry.
.github/workflows/ci.yml Updated Python version matrix to exclude "3.7"; added Git user configuration step; simplified checkout steps.

Poem

In the garden where code does play,
A version blooms, bright as the day.
From beta's shade to stable light,
Dparse hops forth, a joyful sight!
With classifiers neat, it takes its stand,
A project refined, oh, isn't it grand? 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5409ddb and 06736eb.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (1 hunks)
  • pyproject.toml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/ci.yml
  • pyproject.toml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pyproject.toml (1)

25-25: Formatting improvement for Python 3.12 classifier.

The trailing whitespace has been removed from the Python 3.12 classifier entry. This is a good practice for maintaining clean and consistent code.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2401c39 and 2241290.

📒 Files selected for processing (1)
  • pyproject.toml (3 hunks)
🧰 Additional context used
🔇 Additional comments (3)
pyproject.toml (3)

7-7: Version bump to 0.6.4 looks good.

The version has been updated from "0.6.4b0" to "0.6.4", indicating a transition from a beta to a stable release. This change aligns with the PR objectives.


82-82: Verify the addition of changelog_incremental = false.

A new configuration option for commitizen has been added: changelog_incremental = false. This setting typically results in generating a full changelog each time, rather than an incremental one.

Could you please confirm if this change is intentional and explain its purpose? It's worth noting that this modification wasn't mentioned in the PR description or summary.


Line range hint 1-82: Overall review summary

The main objective of this PR, which was to bump the version to 0.6.4, has been successfully implemented. The changes are minimal and mostly as expected, with good attention to detail in formatting.

However, there's an additional change to the commitizen configuration (changelog_incremental = false) that wasn't mentioned in the PR description. While this change doesn't affect the version bump itself, it could impact how changelogs are generated in the future. It would be beneficial to have more context on why this change was made and ensure it aligns with the project's changelog management strategy.

@jakub-safetycli jakub-safetycli added minor This PR causes a minor bump in the version number. maintenance Generic maintenance tasks. labels Oct 18, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.github/workflows/ci.yml (1)

Line range hint 36-36: Consider implementing quality, security, and style checks

There's a TODO comment about enforcing quality, security, and style checks in the CI workflow. Implementing these checks would significantly improve the overall code quality and security of the project.

Would you like assistance in implementing these checks? I can suggest some common tools and configurations for Python projects, such as:

  • Flake8 for style checks
  • Bandit for security checks
  • Black for code formatting
  • MyPy for type checking

Let me know if you'd like me to provide a sample configuration for any of these tools.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2241290 and 943e5fa.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (1 hunks)
  • pyproject.toml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
🧰 Additional context used
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

21-21: Approved: Python version update in CI workflow

The removal of Python 3.7 from the testing matrix is consistent with the version bump to 0.6.4. This change focuses the CI process on more recent Python versions (3.8 to 3.12), which is a good practice for maintaining up-to-date compatibility.

To ensure this change is reflected in the project documentation, please run the following script:

If the script returns results mentioning Python 3.7 support, consider updating the documentation to reflect the new supported versions.

@jakub-safetycli jakub-safetycli removed the minor This PR causes a minor bump in the version number. label Oct 18, 2024
@@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 3.7 is no longer available on macos causing the GitHub action to fail.

@jakub-safetycli jakub-safetycli force-pushed the release/0.6.4 branch 2 times, most recently from 5409ddb to a5af2da Compare October 18, 2024 19:37
@jakub-safetycli jakub-safetycli force-pushed the release/0.6.4 branch 2 times, most recently from 1a80ef6 to a4c7989 Compare November 4, 2024 21:30
Copy link
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@jakub-safetycli jakub-safetycli merged commit b8a13b4 into main Nov 8, 2024
21 checks passed
@dylanpulver dylanpulver deleted the release/0.6.4 branch November 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants