-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix marking branch for removal after merge in Gitlab #348
Fix marking branch for removal after merge in Gitlab #348
Conversation
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 93.92% 94.20% +0.28%
==========================================
Files 11 11
Lines 1103 1157 +54
==========================================
+ Hits 1036 1090 +54
Misses 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to me. Unfortunately, as @htgoebel suggested, we should restrict the change-set to the actual GitLab call. We should have people relying on the actual old config values, and until we have means to be able to gracefully deprecate that, we need to keep supporting the old config.
Can you restrict the change-set to the GitLab call and any respective test whether pertinent?
90d9689
to
1556368
Compare
Thanks for showing where the problem was, @WouldYouKindly 👍 |
@rafaelpivato thanks for taking the time to fix it! |
Hi.
I renamed
should_remove_source_branch
toremove_source_branch
, and flag is now correctly set on merge request.Tested on GitLab Community Edition 11.9.4
According to https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/api/merge_requests.md#L745