-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package coverage<6.0b1
incorrectly listed as vulnerable
#2335
Comments
I'm interested to know more about how entries get created in this database in the first place. You seem to have used words from my CHANGELOG, so there's a human making the entries. If you notify the owner of the repo, then we could short-circuit some of the churn around entries like this that are more alarming than they need to be. |
safety-db read this entry and reported it as a security issue. It was never a security problem. pyupio/safety-db#2335
safety-db read this entry and reported it as a security issue. It was never a security problem. pyupio/safety-db#2335 https://nedbat.github.io/coverage-reports/reports/20210802_6adbefa71a/htmlcov 6adbefa71a: master
Hi @whyscream, thanks for reporting this issue. We reviewed in detail and this was a false positive, we have marked the vulnerability as INVALID and the update will be available soon. @nedbat we usually notify repo owners to clarify the possible vulnerability, this time MD5 was a red flag (even FIPS blocks it regardless of context) for our security team while doing the verification (about your question, there is a security team checking each possible vulnerability). We will reach you if the security team has questions about a possible vulnerability. |
It's just a little disappointing that my change was specifically to silence a false alarm that had been reported, and my change caused you to create another false alarm. :( |
Do we have an ETA on when this false alarm will be fixed by updates? |
Hi @nedbat I know what you mean, sorry for that, I think a more detailed clarification in changelogs will help to don't produce false positives in the future and our team probably will reach you next time if a security item in the changelog isn't clear for them. @awsbillz the correction was done after this issue was reported, it will show up for our paid users immediately and not until September 1st for our users without a paid subscription. We can review/accept any PR in an expedited way if you want to remove the false positive before that date. You will have to remove the vulnerability from: insecure.json and insecure_full.json |
@yeisonvargasf done: #2337 |
Remove `coveragepy` from vulnerable, refs #2335
As discussed in nedbat/coveragepy#1198 with the author of the coverage package. The former usage of the md5 algorithm in coverage is not a security vulnerability. The listing in safety-db forces (or rather tries to convince) lots of people to upgrade to a newer version that is both beta and a major upgrade, for no good reason (security-wise).
Would you consider removing the entry for coverage<6.0b1 from the database?
The text was updated successfully, but these errors were encountered: