Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: Urllib3 #481

Closed
wants to merge 1 commit into from
Closed

Conversation

gdrosos
Copy link

@gdrosos gdrosos commented Aug 10, 2023

Summary

This pull request removes the unused dependency urllib3 from the setup.cfg and the test_requirements.txt configuration files. The removal is a finding from ongoing research focused on identifying and eliminating code bloat within software projects.

Rationale

The urllib3 dependency was introduced in 509f977, but it appears to be unused within the source code. As this dependency is unnecessary, its removal will simplify the project's dependency management and reduce the project's overall footprint.

Changes

  • Removed the urllib3 dependency from the setup.cfg file.

Impact

  • Reduced Package Size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified Dependency Tree: Fewer dependencies make the project easier to maintain and can speed up installation.

This change aligns with the best practices in maintaining a clean and optimized codebase.

@gdrosos gdrosos changed the title Remove unused dependency: urllib3 Remove Unused Dependency: Urllib3 Aug 10, 2023
@oz123
Copy link

oz123 commented Aug 19, 2023

Requests depends on urllib3. There is no direct usage of it, so it's probably safe to remove.

@gdrosos
Copy link
Author

gdrosos commented Sep 13, 2023

Hello @yeisonvargasf ,

I hope this message finds you well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as a maintainer would greatly contribute to our research efforts.

Could you please take a moment to review these changes? Your input would be highly valuable to us.

Thank you for your consideration!

@Zeckie
Copy link
Contributor

Zeckie commented Jun 5, 2024

As requests uses urllib3, removing this dependency will not result in fewer dependencies to install.

urllib3>=1.26.5 - was that version chosen for some reason (for example, was there a bug or vulnerability that was fixed in that version that might affect safety)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants