Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pip and pipenv versions for now #469

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Pin pip and pipenv versions for now #469

merged 2 commits into from
Oct 12, 2018

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Oct 12, 2018

pipenv is broken by:

pypa/pipenv#2956

@hroncok hroncok added the WIP label Oct 12, 2018
@hroncok
Copy link
Member Author

hroncok commented Oct 12, 2018

This is broken, yet no idea what's going on :(

@encukou
Copy link
Member

encukou commented Oct 12, 2018

I assume pipenv install git+https://github.com/pyvec/arca.git@pip_pipenv#egg=arca overrides Pipfile's arca = {extras = ["docker"], version = ">= 0.3"}, so docker doesn't get pulled in.

@hroncok hroncok force-pushed the pin_pip_pipenv branch 2 times, most recently from 41390ac to 48b8997 Compare October 12, 2018 12:31
@hroncok
Copy link
Member Author

hroncok commented Oct 12, 2018

Holy hell. pypa/pipenv#2504

@hroncok
Copy link
Member Author

hroncok commented Oct 12, 2018

I still see:

$ pipenv run naucse list_courses
Usage: __main__.py [OPTIONS] COMMAND [ARGS]...
Try "__main__.py --help" for help.
Error: No such command "list_courses".

But it does something... let's see if it doesn't render error messages everywhere.

@encukou
Copy link
Member

encukou commented Oct 12, 2018

I guess this also brings in a newer click, which normalizes list_courses to list-courses.
So many normalization issues!

@hroncok
Copy link
Member Author

hroncok commented Oct 12, 2018

I wonder how gets click 7 installed when we explicitly have it pinned in Pipfile.lock, and it's not brought in by install arca or docker.

@hroncok hroncok removed the WIP label Oct 12, 2018
@hroncok hroncok requested a review from encukou October 12, 2018 15:07
@hroncok
Copy link
Member Author

hroncok commented Oct 12, 2018 •
edited
Loading

I've tried to set the click version to >=7 or <7 but I fail to generate new Pipfile.lock with weird GitPython related errors. I've had enough. I explicitly set the name for the command to contain dash, so it now works with both click 6 and 7.

This can now go in. It's an ugly hack, but still a better than having @encukou deploying the site manually every day.

@hroncok hroncok added the forks label Oct 12, 2018
@encukou encukou merged commit b0782b6 into pyvec:master Oct 12, 2018
encukou pushed a commit that referenced this pull request Oct 12, 2018
@hroncok @encukou
Name the list-courses command explicitly with dash to avoid surprises
e363044 
See #469 (comment)
@encukou
Copy link
Member

encukou commented Oct 12, 2018

Thank you!

@hroncok hroncok deleted the pin_pip_pipenv branch October 12, 2018 19:21
hroncok added a commit to cvut/naucse.python.cz that referenced this pull request Oct 17, 2018
@hroncok
Name the list-courses command explicitly with dash to avoid surprises
e091944 
See pyvec#469 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
forks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hroncok @encukou