Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open_timeout stored in Session #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skrchnavy
Copy link

parameter open_timeout is passed to session and stored there. Can be used in derived classes.
No further processing is done, just interface changes

It aligns code with the change in pyvisa/pyvisa-py#115 due to requirements in pyvisa/pyvisa-py#88

@MatthieuDartiailh
Copy link
Member

This breaks all tests because you would need to change the __init__ of all subclasses. I am not sure how useful that is since the simulator does not care about the timeout neither do the user (as I expect user to interact through the highlevel API and not dig into the session). What is your reasoning behind this ?

@skrchnavy
Copy link
Author

Reason was to be able to simulate connection timeout. I will check if it is worth to invest there an effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants