> We can still make pylint happy in a follow up PR if necessary 👍
#39
Comments
tkoyama010
added a commit
to tkoyama010/pyvistaqt
that referenced
this issue
Jul 27, 2020
Merged
akaszynski
pushed a commit
that referenced
this issue
Aug 23, 2020
* Add pylint in CI #39 * Improve rating to 8.87/10 * Fix codespell conf * Install dependencies * Setup python first * Use python 3.6 * Fix workflow * Restore workflow * Update .github/workflows/pythonpackage.yml * Fix C0103: invalid-name * Fix C0103 invalid-name * Add pylint Makefile target * Fix C0103 invalid-name * ♻️ fix by pylint * Fix Makefile * Move dragEnterEvent to function * Fix pylint error * Fix W0611 unused-import * Fix W0613: unused-argument * Fix isort * Revert of comment * Fix unnecessary-lambda * Fix unnecessary-lambda * Fix invalid name * Fix unused variable * Disable conflicting rule between black and pylint See : psf/black#48 pylint-dev/pylint#289 * Fix reimported (W0404) * Fix C0412 (ungrouped-imports) * Fix missing-module-docstring * Fix too-many-arguments * Fix broad-except * Fix invalid-name * Fix disable to name * Fix too-many-instance-attributes * Fix pylint * Fix black * Fix invalid-name * Fix too-many-arguments * Update pyvistaqt/window.py * Update pyvistaqt/dialog.py * Fix pylint * Fix too-few-public-method * Fix too-few-public-methods * Remove enable F401 * Revert "Remove enable F401" This reverts commit c937bc5. * Fix attribute-defined-outside-init * Fix too-few-public-methods * Fix unsubscriptable-object * Fix unsubscriptable-object * Fix pycodestyle * Fix isort * Fix typo * Update pyvistaqt/plotting.py * Fix unnecessary-lambda * Update dialog.py * Update pyvistaqt/dialog.py * Update pyvistaqt/dialog.py * Update pyvistaqt/dialog.py * Update pyvistaqt/dialog.py * Fix invalid-name * Update pyvistaqt/dialog.py * Update pyvistaqt/dialog.py * Update pyvistaqt/dialog.py * Fix unused-argument * Fix at least two spaces before inline comment * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Fix invalid-name * Update plotting.py * Update plotting.py * Fix no-self-use * Fix attribute-defined-outside-init * Fix attribute-defined-outside-init * Fix attribute-defined-outside-init * Fix E261 at least two spaces before inline comment * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Fix attribute-defined-outside-init * Update pyvistaqt/window.py * Fix no cover * Update pyvistaqt/plotting.py * Update pyvistaqt/plotting.py * Fix pylint * Restore imports and adds docstrings * Deal with PyQt5 ungrouped-imports * Make isort * Add docstring Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>
|
Closing by #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OK. Let's make pylint PR next time. Could you merge this PR first?
Originally posted by @tkoyama010 in #38 (comment)
The text was updated successfully, but these errors were encountered: