fix(typehint): use redundant alias imports for mypy #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also better aligns the repo with `pyvista/CONTRIBUTING.md`. Fixes Issue #163
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 97.22% 96.94% -0.29%
==========================================
Files 8 8
Lines 648 654 +6
Branches 90 90
==========================================
+ Hits 630 634 +4
- Partials 18 20 +2 |
tkoyama010
requested changes
Jun 26, 2022
.gitignore
Outdated
| ======= | ||
| # virtual environments | ||
| .venv/ | ||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
Ya, nearly all the tests are failing for me in this repo and several simply do not run:
There was a problem hiding this comment.
I think this will need some TLC ❤️
… back Editor-specific files should be ignored in global settings. Certain `ini` files are still used in the `Makefile`, so should be kept.
|
I need to do some cleanup (something went wrong when I forked the repo). I will close this and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also better aligns the repo with
pyvista/CONTRIBUTING.md.Fixes Issue #163