-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add pinch-to-zoom #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Let me know when we need to push a release.
@larsoner, once you've been approved as a developer, you should be able to merge the PR. Let me know if you have any issues. |
@hoechenberger can you test and verify that it works for you ? |
Will give it a shot in a couple hours and report back |
I think that's just as fast as the events get processed by qt. I experience the same thing with the scroll wheel |
Smooth scrolling is possible while holding the control key (mac) plus click and drag. You may be able to use those same events to control the smoothness? |
Indeed this does work! I keep pressing Ctrl and then use pinch-to-zoom, and it's smooth. I think this behavior should be the default for pinch zooming :) |
I'm not sure if we can (or should) change that default zoom style. There may be performance concerns. The change would likely be upstream in PyVista though |
I'm just talking about the new pinch zooming :) All other existing zoom functionality can remain the same. |
I can also get this behavior by pressing right mouse button and then scrolling. |
You may be able to trigger the control key events with what was implemented here to do it |
Closes #19