-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static pattern matching framework, orientation similarity map and crystal map merging #234
Conversation
Framework for calculating similarities between 2D gray-tone images of equal size.
length of shape -> ndim, and removed unnecessary squeeze call.
Produce value of 1 with equal pattern and template
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…y into similarity-metrics
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Change data shape from (N,nm) to (nm,N) to correspond better with cdist in scipy and general logic.
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
I've done several changes, including:
Minor docstring changes. Haven't updated the tests, so they will fail. |
@onatlandsmyr, do you have any comments to the changes I've made? I think what's left now is
I continue on this now, if that's okay with you. Edit: add touching up the |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Have tested |
I just want to note that EMsoft now supports both NDP and NCC: EMsoft-org/EMsoft@9b56e35. Edit: I actually think we should call it NCC instead of ZNCC, what do you think @onatlandsmyr? Edit2: It seems like NCC was added to EMsoft for computing similarities between experimental/simulated Kossel patterns. |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
I've made all the docstring, test and code structure changes I plan to do now. Since I'm the one who've made the last changes, I would appreciate it if you @onatlandsmyr could go over it, and make or suggest any changes you would like, and then we can merge! Edit: I suggest also having a look at the API reference for any changes you may want: https://kikuchipy--234.org.readthedocs.build/en/234/reference.html#module-kikuchipy.indexing Edit2: We should decide if we want to call it
|
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
I have updated the top comment to reflect the pattern matching progressbar updates. |
All the changes look very good and promising, thank you very much @hakonanes. I agree with all the refactoring of names and I like the new additional progress bar. When it comes to naming things, I generally trust you more than me seeing you have more experience in the field. EDIT: |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
These names are now used, with the dictionary indexing references to Chen et al. (2015), Marquardt et al. (2017) and Jackson et al. (2019) kept. |
I'll merge when you give me the green light, @onatlandsmyr! |
Static pattern matching and Orientation Similarity Map
Indexing against pre-computed dictionaries with simulated patterns from for example EMsoft's EMEBSD.f90 program or, hopefully soon, our own sampling from master patterns.
Produce a
CrystalMap
for each dictionary withscores
andsimulated_indices
as properties. A merged CrystalMap and orientation similarity maps as propertyosm
if wanted.Depends on #233 and #231.
Progress of the PR
Minimal example of the bug fix or new feature
Note that the progressbar shows the phase name and memory used.
For reviewers
later.
__init__.py
.the unreleased section in
doc/changelog.rst
.