Merge pull request #533 from viljarjf/speedup-miller-rotation

Avoid expensive deepcopy when rotating Miller
pyxem · Dec 15, 2024 · 8ac149f · 8ac149f
2 parents 0daa809 + c3a4dda
commit 8ac149f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/orix/quaternion/rotation.py b/orix/quaternion/rotation.py
@@ -117,8 +117,9 @@ def __mul__(
             return Q
         if isinstance(other, Vector3d):
             v = Quaternion(self) * other
-            improper = (self.improper * np.ones(other.shape)).astype(bool)
-            v[improper] = -v[improper]
+            if np.any(self.improper):
+                improper = (self.improper * np.ones(other.shape)).astype(bool)
+                v[improper] = -v[improper]
             return v
         if isinstance(other, int) or isinstance(other, list):  # abs(1)
             other = np.atleast_1d(other).astype(int)