Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set decorationState.[[Finished]] to true when decorator throws #13

Open
wants to merge 2 commits into
base: decorators
Choose a base branch
from
Open

Set decorationState.[[Finished]] to true when decorator throws #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7886cc8
Set decorationState.[[Finished]] to true when decorator throws
nicolo-ribaudo Feb 8, 2024
84536da
Also fix in ApplyDecoratorsToClassDefinition
nicolo-ribaudo Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24741,8 +24741,9 @@ <h1>
1. Set _value_ to OrdinaryObjectCreate(%Object.prototype%).
1. Perform ! CreateDataPropertyOrThrow(_value_, *"get"*, _elementRecord_.[[Get]]).
1. Perform ! CreateDataPropertyOrThrow(_value_, *"set"*, _elementRecord_.[[Set]]).
1. Let _newValue_ be ? Call(_decorator_, _decoratorReceiver_, « _value_, _context_ »).
1. Let _newValue_ be Completion(Call(_decorator_, _decoratorReceiver_, « _value_, _context_ »)).
1. Set _decorationState_.[[Finished]] to *true*.
1. ReturnIfAbrupt(_newValue_).
1. If _kind_ is ~field~, then
1. If IsCallable(_newValue_) is *true*, prepend _newValue_ to _elementRecord_.[[Initializers]].
1. Else if _newValue_ is not *undefined*, throw a *TypeError* exception.
Expand Down Expand Up @@ -24793,8 +24794,9 @@ <h1>
1. Let _decoratorReceiver_ be _decoratorRecord_.[[Receiver]].
1. Let _decorationState_ be the Record { [[Finished]]: *false* }.
1. Let _context_ be CreateDecoratorContextObject(~class~, _className_, _extraInitializers_, _decorationState_).
1. Let _newDef_ be ? Call(_decorator_, _decoratorReceiver_, « _classDef_, _context_ »).
1. Let _newDef_ be Completion(Call(_decorator_, _decoratorReceiver_, « _classDef_, _context_ »)).
1. Set _decorationState_.[[Finished]] to *true*.
1. ReturnIfAbrupt(_newDef_).
1. If IsCallable(_newDef_) is *true*, then
1. Set _classDef_ to _newDef_.
1. Else if _newDef_ is not *undefined*, then
Expand Down
Loading