Skip to content

Commit

Permalink
[MRESOLVER-356] Remove Guava (s4u#289)
Browse files Browse the repository at this point in the history 
Guava is not used anywhere in codebase, but as transitive dependency of Guice was "controled", but this makes no sense.

---

https://issues.apache.org/jira/browse/MRESOLVER-356
  • Loading branch information
@cstamas
cstamas authored Jun 1, 2023
1 parent 7dfd789 commit 0b48b1f
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 127 deletions.
10 changes: 0 additions & 10 deletions maven-resolver-connector-basic/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,6 @@
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
12 changes: 0 additions & 12 deletions maven-resolver-demos/maven-resolver-demo-snippets/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,6 @@
<artifactId>guice</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>runtime</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>runtime</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down
12 changes: 0 additions & 12 deletions maven-resolver-impl/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,6 @@
<scope>provided</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>runtime</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>runtime</scope>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down
10 changes: 0 additions & 10 deletions maven-resolver-transport-classpath/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,6 @@
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
10 changes: 0 additions & 10 deletions maven-resolver-transport-file/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,6 @@
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
10 changes: 0 additions & 10 deletions maven-resolver-transport-http/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,6 @@
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
10 changes: 0 additions & 10 deletions maven-resolver-transport-wagon/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,6 @@
<artifactId>guice</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
53 changes: 0 additions & 53 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@
<checkstyle.violation.ignore>None</checkstyle.violation.ignore>
<sisuVersion>0.3.5</sisuVersion>
<guiceVersion>5.1.0</guiceVersion>
<guavaVersion>31.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
<minimalMavenBuildVersion>[3.8.7,)</minimalMavenBuildVersion>
<minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
Expand Down Expand Up @@ -215,57 +213,6 @@
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<version>${guiceVersion}</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<!-- This is a transitive dep of com.google.inject:guice -->
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>${guavaVersion}</version>
<scope>runtime</scope>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
<artifactId>jsr305</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.guava</groupId>
<artifactId>listenablefuture</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.j2objc</groupId>
<artifactId>j2objc-annotations</artifactId>
</exclusion>
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<!-- This is a transitive dep of com.google.guava:guava -->
<groupId>com.google.guava</groupId>
<artifactId>failureaccess</artifactId>
<version>${guavafailureaccessVersion}</version>
</dependency>

<dependency>
Expand Down

0 comments on commit 0b48b1f

Please sign in to comment.