Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request extracts file upload logic into a new utility module that implements S3 presigned URL-based file uploads with polling verification for non-PDF files. The MakeQuiz component now imports this utility and updates its error handling to show user-friendly messages instead of rethrowing exceptions. Changes
Sequence DiagramsequenceDiagram
participant MakeQuiz as MakeQuiz Component
participant Backend as Backend API
participant S3 as AWS S3
MakeQuiz->>Backend: POST /s3/request-presign<br/>(fileName, contentType, fileSize)
Backend-->>MakeQuiz: {uploadUrl, finalUrl, isPdf}
MakeQuiz->>S3: PUT uploadUrl<br/>(file, headers)
S3-->>MakeQuiz: Upload successful
alt isPdf == false
rect rgba(100, 150, 200, 0.5)
Note over MakeQuiz: Polling Loop (2s intervals, max 60s)
loop Until "EXIST" or timeout
MakeQuiz->>Backend: GET /s3/check-file-exist?url=finalUrl
Backend-->>MakeQuiz: {status}
end
end
end
MakeQuiz-->>MakeQuiz: Return finalUrl
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📢 설명
해당 Pull Request에 대해 간략하게 설명해주세요!
✅ 체크 리스트
Summary by CodeRabbit
Bug Fixes
Updates
✏️ Tip: You can customize this high-level summary in your review settings.