-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]rtmp pull增加ack应答提高兼容性 #154
Conversation
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 60.03% 59.76% -0.27%
==========================================
Files 114 114
Lines 9000 9022 +22
==========================================
- Hits 5403 5392 -11
- Misses 3004 3043 +39
+ Partials 593 587 -6
Continue to review full report at Codecov.
|
pkg/rtmp/client_session.go
Outdated
@@ -120,6 +123,7 @@ func NewClientSession(t ClientSessionType, modOptions ...ModClientSessionOption) | |||
}, | |||
debugLogReadUserCtrlMsgMax: 5, | |||
hc: hc, | |||
peerWinAckSize: peerBandwidth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否需要初始化为 peerBandWidth,
初始化为 peerBandWidth则默认回复ack了,
是否只由收到 RtmpTypeIdWinAckSize 才回复ack更合适?
这个做法是参考了什么开源项目吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看到你下面说参考srs了,最好再找一个开源实现做对比,比如nginx-rtmp-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
初始化可能就搞成option设置更好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我同意放option中。
srs中,对应的是in_ack_size吗?我看它配置中的默认值是0?
所以你也放option中,并且默认值为0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,srs不做客户端它是可以配置文件配置。option提交了
No description provided.