Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch to master for: logging attempts to and asks for as trace level log messages #258

Conversation

Pressacco
Copy link
Contributor

@Pressacco Pressacco commented Mar 15, 2023

Description

  • Tasks & async Tasks
    • pre-interaction log messages (e.g. attempts to) are recorded as Trace
  • Questions & async Questions
    • pre-interaction log messages (e.g. asks for) are recorded as Trace

NOTE: This Pull Request assumes that the following (pending) pull request has been merged to master

Testing

  • Added unit tests for Task and Question
    • pre-interaction, and
    • post-interaction
  • Did not add unit tests for asynchronous tasks & questions. I can do so if you wish.

Checklist

  • I agree to follow Boa Constrictor's Code of Conduct.
  • I read Boa Constrictor's Contributing Code guide.
  • I successfully built the .NET solution with no errors or new warnings.
  • I successfully ran both the unit tests and the example tests.
  • I updated the appropriate changelogs with concise descriptions of these changes.
  • I added documentation for these changes (if appropriate).

@Pressacco
Copy link
Contributor Author

I hope that you are ok with this proposed change @pl-aknight

@AutomationPanda
Copy link
Contributor

This one is also definitely on the docket. Thanks for the contribution!

Copy link
Contributor

@AutomationPanda AutomationPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work here.

@AutomationPanda AutomationPanda merged commit b59d2b3 into q2ebanking:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants