better flag assets paths; works if plugin is installed as mu-plugin #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnclause
added a commit
that referenced
this pull request
May 30, 2015
better flag assets paths; works if plugin is installed as mu-plugin
|
Thank you, @entr, although I do not see a benefit in using 'path_join', it seems to only increase the execution time. There is a lot more places where string 'plugins' is in use. I was always worried about it. I also watch for problems when people link some of the folders in the path to plugin to somewhere else, then FILE has link-resolved value and sometimes it is a trouble. I am not sure about the best way to deal with all of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of course this doesn't provide full mu-plugin support but it is a step.