Fix for the "note added to your order" mail (+ possibly others sent over ajax) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls are sent in the language the customer used during the order process Needed, so the "note added to your order" mails are sent in the correct language Issue qTranslate-Team#3
johnclause
added a commit
that referenced
this pull request
Apr 1, 2015
Fix for the "note added to your order" mail (+ possibly others sent over ajax)
|
I am a bit confused, why would we add another function on the same filter? Cannot we do all in one function? I can merge it in one if you do not mind? |
|
I see a few reasons as to why not to combine them. Keeping them separate increases readability because the functions stay more modular. Also, both of these filters are more like "worarounds" than really clean solutions, so If one of the needs to be replaced for a future WooCommerce update, it's "tidyer" if there are separate functions. A third reason is that you can disable them individually for testing purposes by just commenting out the corresponding "add_filter" line. |
|
Yes, that all makes sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append the language to ajax links on the order edit page, so that mails are sent in the language the customer used during the order process
Needed, so the "note added to your order" mails are sent in the correct language
Issue #3