Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

setState and saveState utils #18

Merged
merged 12 commits into from
Mar 6, 2020
Merged

setState and saveState utils #18

merged 12 commits into from
Mar 6, 2020

Conversation

flaurida
Copy link
Contributor

@flaurida flaurida commented Mar 6, 2020 •
edited by jperl
Loading

@flaurida
Copy link
Contributor Author

flaurida commented Mar 6, 2020

On reflection think setState is a better name than loadState, can make the changes

@jperl jperl changed the title loadState and saveState utils setState and saveState utils Mar 6, 2020
@jperl
Copy link
Member

jperl commented Mar 6, 2020 •
edited
Loading

Blocked on microsoft/playwright#1269, microsoft/playwright#1258

@jperl jperl marked this pull request as ready for review March 6, 2020 21:56
jperl
jperl approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@jperl jperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After (non turned off) tests pass 👍

@flaurida flaurida merged commit 2eeb74a into master Mar 6, 2020
@flaurida flaurida deleted the save-state branch March 6, 2020 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jperl jperl jperl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💾setState(page, path), saveState(page, path)
2 participants
@flaurida @jperl