setRowStyle function not working

[eduardo-mior]

Description
setRowStyle function not working.

I need to define the style of a line but this is not working in Excel and GoogleSheets, interestingly in LibreOffice Calcs it works.

Code example:

xlsx.SetSheetName("Sheet1", "Report")

titleStyle, err := xlsx.NewStyle(&excelize.Style{
	Font: &excelize.Font{
		Bold: true,
		Size: 20,
	},
	Alignment: &excelize.Alignment{
		Vertical: "center",
	},
})
if err != nil {
	return "", nil, err
}

if err := xlsx.SetCellValue("Report", "A1", "Customers Report"); err != nil {
	return "", nil, err
}

if err := xlsx.SetRowStyle("Report", 1, 1, titleStyle); err != nil {
	return "", nil, err
}

if err := xlsx.SetRowHeight("Report", 1, 30); err != nil {
	return "", nil, err
}

if err := xlsx.MergeCell("Report", "A1", "Z1"); err != nil {
	return "", nil, err
}

xlsx.SaveAs("teste.xlsx")

Describe the results you received:
GoogleSheets and Excel:

Describe the results you expected:
LibreOffice:

Output of go version:

go version go1.17.3

Excelize version or commit ID: 2.5.0

Environment details (OS, Microsoft Excel™ version, physical, etc.):
MacOS Catalina AND Linux Zorion OS
GoogleSheets (online), Libre Office (linux), Excel 2021 (macos from app store)

[xuri]

Thanks for your issue. Please set the style for the cells in the merged range like this:

err := xlsx.SetCellStyle("Report", "A1", "Z1", titleStyle)

[eduardo-mior]

Many thanks for the reply.

[eduardo-mior]

Do you plan to resolve this issue in a future release? I noticed that you closed the issue but didn't leave any other comments.

[xuri]

I have fixed it, please upgrade to the master branch code, and this patch will be released in the next version.

[kukaki]

@xuri

SetRowStyle is not replacing the style of a cell (part of the row) which was previously set using SetCellStyle.

For eg. Let's say I have set style to column A using SetColStyle. Now if I set style to row 1 using SetRowStyle, the row style is applied to entire row 1 except cell A1 (col style prevailing here).

i.e. SetRowStyle is setting style to only the cells which do not have a previous style.

It is not intended, right?

[xuri]

Hi @kukaki, sorry for my late reply, I have made the SetRowStyle overwrite style of the cells on commit 773d4af, please upgrade to the master branch code, and this patch will be released in the next version.

[xuri]

Hi @eduardo-mior, I also notice that according to the benchmark report of v2.6.0, this fix (commit: 156bf6d) slows down set sheet row and the merging cell about 400 times.

[xuri]

Hi @eduardo-mior, I have improved performance for the set sheet row and the merging cells on commit eed431e, fixed performance impact when resolving this issue, and this patch will be released in the next version.

[michaelperel]

@xuri I am not sure if this is the same issue (I recently started using the library), however:

In the latest v2 release, when I set a row style for 1 row, and then write data into row 2, 3, 4 and so on, the style from row 1 is applied to all rows. I would expect the style to only apply to row 1, not subsequent rows.

In master (commit: eed431e), the behavior is as I would have expected - If I set the style for row 1 and then write row 2, the style from row 1 does not apply to row 2.

So that is to say, master is working great for me!

[xuri]

@michaelperel, yep, this issue was caused by an incorrect row compare condition on cell style inheritance in commit 156bf6d.