AddPicture Method Not Respecting AutoFit and LockAspectRatio in GraphicOptions

[t4traw]

Description

I'm experiencing an issue with the AddPicture method in the excelize package. Despite setting AutoFit to true and LockAspectRatio to true in GraphicOptions, it seems that the aspect ratio is only respected in the vertical direction, not in the horizontal direction. As a result, the images are distorted and do not fit correctly within the cells.

Here's the relevant part of my code:

package main

import (
	_ "image/jpeg"

	"github.com/xuri/excelize/v2"
)

func main() {
	xlsx, _ := excelize.OpenFile("base.xlsx")
	pos, _ := xlsx.SearchSheet("Sheet1", "[photo]")
	graphicOptions := excelize.GraphicOptions{
		AutoFit:         true,
		LockAspectRatio: true,
	}
	xlsx.AddPicture("Sheet1", pos[0], "400x300.jpg", &graphicOptions)
	xlsx.SaveAs("output.xlsx")
}

Describe the results you received:

file: base.xlsx

file: output.xlsx

Output of go version:

go version go1.19 darwin/arm64

Excelize version or commit ID:

2.7.1

Environment details (OS, Microsoft Excel™ version, physical, etc.):

• OS: macOS 13.3.1
• Excel: 16.72

Any help on this issue would be greatly appreciated. Thank you!

[yamato1413]

I have encountered the same problem too.

picture.go:drawingResize resizes the image while maintaining the aspect ratio.
Afterwards, col.go:positionObjectPixels calculates the cell to be pasted. I could not find any errors in the logic here either.

I suspect col.go:getColWidth.

I set the A1 cell to 300x300 px in Excel and ran AddPicture.
col.go:getRowHeight output 300 px, but col.go:getColWidth output 268 px.
Based on these values, picture.go:drawingResize was executed, resulting in an image size of 268x268px. (The image size should be 300x300px)
In col.go:positionObjectPixels the Column process is calculated according to the wrong cell width. Here a 268px wide image is enlarged to a 300px cell width.
The Row process knows the correct cell height and sets a 268px image.
This results in the aspect ratio being broken.(300x268px)

go version:

go version go1.20.4 windows/amd64

excelize version:

2.7.1

os:

Windows 10 Pro 22H2

excel:

Microsoft® Excel® for Microsoft 365 MSO (version 2304 build 16.0.16327.20200) 32 bit 

[xuri]

Hi @t4traw, thanks for your issue. I have tested with your code and it seems works well. Could you provide the base.xlsx and 400x300.jpg as a attachments?

[xuri]

Hi @yamato1413, thanks for your feedback. The problem as your mentions was related to the issues #260, #279, #569 and #1419.

[t4traw]

@xuri Thank you for response! I'm sending a zip of the code tested in my environment along with the output results (also, I've created a repository for it https://github.com/t4traw/excelize_addPicture_sample).
Thank you for such a wonderful library!

sample.zip

[xuri]

Thanks for your feedback. I have fixed this issue, please try to upgrade the master branch code, and this patch will be released in the next version.

[t4traw]

@xuri Thank you! I'm looking forward to the v2.8.0!

[t4traw]

@xuri I immediately tried out the commit contents of the master branch! It seems better than before, but it still appears the scale value is off. I've attached the re-output results as a zip file.

sample_ 08ba272.zip

[xuri]

Thanks for your feedback. I changed the default point to the pixels conversion factor for a better scale effect. But we still can't get the exact scaling percentage, related to I replies in issue #569, the image scaling depends on each row's height and column's width, these storage inner workbook files with pt units, we need to covert it into pixels, since this conversion was effected by device DPI, so we can't be made the conversion result fit any devices. As you open the same workbook with an image in a difference spreadsheet application, operation system, or client device, the size of an image may be different, so please adjust the scale by image options as you need.