Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development - go.mod and gitignore #466

Closed
mlh758 opened this issue Aug 8, 2019 · 4 comments
Closed

Development - go.mod and gitignore #466

mlh758 opened this issue Aug 8, 2019 · 4 comments

Comments

@mlh758
Copy link
Contributor

mlh758 commented Aug 8, 2019

Description

The go.mod seems to be out of sync with the project, every time I build it for tests it is modified:

golang.org/x/image v0.0.0-20190802002840-cff245a6509b

Also, I would like to update the gitignore to ignore the test files that get generated during the test suites execution. Would you accept a PR that updated the gitignore and go.mod?

@dolmen
Copy link
Contributor

dolmen commented Aug 13, 2019

Modification of .gitignore should be a separate PR.

@mlh758
Copy link
Contributor Author

mlh758 commented Aug 13, 2019

Separate PRs for updating .gitignore and the mod file?

@dolmen
Copy link
Contributor

dolmen commented Aug 13, 2019

Yes. .gitignore in one commit in one PR.
For go.mod+go.sum, I think that should be the job of the maintainer because (s)he should know better what the minimum version of the dependencies are supported.

Note that I'm not the maintainer. Just a contributor who follows the project for two years now and uses it in production code.

@bvwells
Copy link
Contributor

bvwells commented Sep 13, 2019

On top of this, building master brings in v1 of the module due to incorrect import paths in test code. See #480.

@xuri xuri closed this as completed in a3ee098 Sep 14, 2019
nullfy pushed a commit to nullfy/excelize that referenced this issue Oct 23, 2020
…/modules

Fix dependency on github.com/360EntSecGroup-Skylar/excelize v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants