Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetSheetIndex description issue #635

Closed
andvary opened this issue May 12, 2020 · 1 comment
Closed

GetSheetIndex description issue #635

andvary opened this issue May 12, 2020 · 1 comment
Labels
kind/documentation Improvements or additions to documentation

Comments

@andvary
Copy link

andvary commented May 12, 2020 •
edited
Loading

Description

There is a mismatch in GetSheetIndex description here and here.

The first one claims the function returns "0" for a non-existing sheet, in the second one it is "-1". As far as I can conclude from testing it myself, the correct one is "0"

Output of go version:

go version go1.14.2 windows/amd64

Excelize version or commit ID:

2.1.0
@xuri xuri added the kind/documentation Improvements or additions to documentation label May 12, 2020
@xuri
Copy link
Member

xuri commented May 12, 2020

Thanks for your feedback, the correct one is "0". I will fix it.

@xuri xuri closed this as completed in dfea8f9 May 12, 2020
Jerome1337 pushed a commit to Jerome1337/excelize that referenced this issue Jun 16, 2020
@xuri @Jerome1337
- New API: SetSheetFormatPr and GetSheetFormatPr
6c0be68 
- typo fix, resolve qax-os#635
nullfy pushed a commit to nullfy/excelize that referenced this issue Oct 23, 2020
@xuri
- New API: SetSheetFormatPr and GetSheetFormatPr
c6973d0 
- typo fix, resolve qax-os#635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuri @andvary