Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Tabs #1108

Merged
merged 4 commits into from
Dec 29, 2021
Merged

Compatible with Tabs #1108

merged 4 commits into from
Dec 29, 2021

Conversation

vst93
Copy link
Contributor

@vst93 vst93 commented Dec 29, 2021

PR Details

Compatible with tabs in string format

Description

add ascii 9

Related Issue

Motivation and Context

I need to write the string ID in pure numbers, but when the length is too long, after editing office will automatically become scientific notation, so I think it needs to be compatible with tabs

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #1108 (3979625) into master (89b8593) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          29       29           
  Lines       18551    18551           
=======================================
  Hits        18197    18197           
  Misses        240      240           
  Partials      114      114           
Flag Coverage Δ
unittests 98.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cell.go 97.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b8593...3979625. Read the comment docs.

@xuri xuri merged commit c5990ea into qax-os:master Dec 29, 2021
@xuri
Copy link
Member

xuri commented Dec 29, 2021

LGTM, thank you @vst93.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants