Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve-vba-thisworkbook-compatibility #1149

Conversation

JDavidVR
Copy link
Contributor

@JDavidVR JDavidVR commented Feb 16, 2022

please refer to this issue: #1148 it has everything documented

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #1149 (9144ff1) into master (ad09698) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1149   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          30       30           
  Lines       18831    18831           
=======================================
  Hits        18499    18499           
  Misses        226      226           
  Partials      106      106           
Flag Coverage Δ
unittests 98.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad09698...9144ff1. Read the comment docs.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2022
@xuri
Copy link
Member

xuri commented Feb 16, 2022

Thanks for your pull request. Because the default code name ThisWorkbook can be changed in the Visual Basic Editor, we need to provide a function to allow users to change it. I have added two exported functions SetWorkbookPrOptions and GetWorkbookPrOptions to support setting and getting the code name property of the workbook. I'll close this PR. Now you can set the codename of the workbook like this:

err := f.SetWorkbookPrOptions(excelize.CodeName("ThisWorkbook"))

@xuri xuri closed this Feb 16, 2022
@JDavidVR JDavidVR deleted the improve-vba-thisworkbook-compatibility branch February 17, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants