-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear data validation #1255
clear data validation #1255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I suggest making the second parameter as optional on the existing function DeleteDataValidation
to delete all data validation on a worksheet instead of introducing a new export function.
… then clear all data validation
I'm not sure if need to traverse DeleteDataValidation's second parameter when make it optional, now I just consider the first element, that is |
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 31 31
Lines 22908 22912 +4
=======================================
+ Hits 22550 22554 +4
Misses 239 239
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM, thanks for your contribution. |
PR Details
Description
add a method to clear data validation
Related Issue
#1254
Motivation and Context
provide a method to clear data validation give by worksheet name when need
How Has This Been Tested
execute TestClearDataValidation
Types of changes
Checklist