Fix NA error

[rpoetrap]

PR Details

Fix NA error

Description

Fix NA error

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[xuri]

Thanks for your pull request. The second parameter of the newErrorFormulaArg function represents the error message, which is used to explain the error string. I purpose making the result of the CalcCellValue function an error string, and the error message of that as the error value. What do you think about that?

[rpoetrap]

I had this problem when trying to use this formula =IFNA(VLOOKUP(...), ...), i thought this problem caused by the Error value in formulaArg is not #N/A?
or should I change the condition in IFNA function from arg.Value() == formulaErrorNA to arg.String == formulaErrorNA?

[xuri]

I means that using formula error string in the result of the CalcCellValue function when error occurs, and using the error message in the CalcCellValue function returns error. I have a changes for all formula functions and updates the unit tests based on your branch. For example:

result, err := f.CalcCellValue("Sheet1", "A1")
// Now, the variable 'result' was not empty when the error occurs
// result: "#N/A"
// err: "HLOOKUP no result found"

[codecov-commenter]

Codecov Report

Merging #1490 (a2d231b) into master (dc3bf33) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1490   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          31       31           
  Lines       24317    24320    +3     
=======================================
+ Hits        23999    24002    +3     
  Misses        210      210           
  Partials      108      108           

Flag	Coverage Δ
unittests	98.69% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
calc.go	99.03% <100.00%> (+<0.01%)	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rpoetrap]

Oh that's perfect, btw I just added a fix to the IFNA function.

[xuri]

LGTM. Thanks for your contribution.