Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add OpenReader options to GetRows #1816

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Fix: Add OpenReader options to GetRows #1816

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b214e6
Fix: Add OpenReader options to GetRows
vivekkairi Feb 14, 2024
7138233
Inc priority of Options + other places handling
Feb 15, 2024
6e6ce35
CalcCellValue ordering fix
Feb 15, 2024
11c3fdf
Handle parent Options in getOptions func
Feb 15, 2024
d2abfbf
Remove Options append
Feb 15, 2024
5bb98ff
Remove multiple time options fetch
Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ func (f *File) GetRows(sheet string, opts ...Options) ([][]string, error) {
return nil, err
}
rows, _ := f.Rows(sheet)
// Adding the OpenReader function options
opts = append(opts, *f.options)
results, cur, max := make([][]string, 0, 64), 0, 0
for rows.Next() {
cur++
Expand Down