Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This closes #1847, support apply number format with alignment #1852

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

lizhichao
Copy link
Contributor

@lizhichao lizhichao commented Mar 18, 2024

This closes #1847, support apply number format with alignment

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (4eb088c) to head (776dff1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1852   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          32       32           
  Lines       23963    23972    +9     
=======================================
+ Hits        23774    23783    +9     
  Misses        101      101           
  Partials       88       88           
Flag Coverage Δ
unittests 99.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 9e884c7 into qax-os:master Mar 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Status: Improve the Compatibility
Development

Successfully merging this pull request may close these issues.

Number format compatibility
2 participants