[BUG] fix Get Rows function memory issues #1875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
fix Get Rows function memory issues that allocate huge amount of memory in special xlsx files
Description
the problem is discussed in the issue
here i just changed it in a way that those empty rows that are located at the end of rows will be ignored
["A", "B", nil, "C", nil, nil] => ["A", "B", nil, "C"]
these nils exist in some special files more than normal
for me was 1 million nils
Related Issue
#1874
Motivation and Context
it was allocating 30Mb of memory for a 10kb file
How Has This Been Tested
discussed in the issue
Types of changes
Checklist