Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function: SearchSheet(), relate issue #277 #278

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

peng
Copy link
Collaborator

@peng peng commented Oct 27, 2018

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #278 into master will decrease coverage by 0.79%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #278     +/-   ##
=======================================
- Coverage   98.79%    98%   -0.8%     
=======================================
  Files          18     18             
  Lines        3823   3854     +31     
=======================================
  Hits         3777   3777             
- Misses         28     59     +31     
  Partials       18     18
Impacted Files Coverage Δ
sheet.go 89.8% <0%> (-8.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bdd36...e2e58a3. Read the comment docs.

@xuri
Copy link
Member

xuri commented Oct 27, 2018

@peng great work. I'll merge this is as is.

@xuri xuri merged commit b917466 into qax-os:master Oct 27, 2018
xuri added a commit that referenced this pull request Oct 28, 2018
New function: `SearchSheet()`, relate issue #277
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants