Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #318, add new functions SetPageLayout and GetPageLayout #330

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

zhangleijlu
Copy link
Contributor

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri changed the title Resolve #318, add new functions and Resolve #318, add new functions SetPageLayout and GetPageLayout Jan 6, 2019
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #330 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #330      +/-   ##
=========================================
+ Coverage   98.89%   98.9%   +<.01%     
=========================================
  Files          18      18              
  Lines        3989    4011      +22     
=========================================
+ Hits         3945    3967      +22     
  Misses         26      26              
  Partials       18      18
Impacted Files Coverage Δ
excelize.go 95.51% <ø> (ø) ⬆️
sheetpr.go 100% <ø> (ø) ⬆️
sheet.go 97.77% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969f4e2...034de7a. Read the comment docs.

@xuri
Copy link
Member

xuri commented Jan 6, 2019

LGTM, thanks.

@xuri xuri merged commit 055d3fa into qax-os:master Jan 6, 2019
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 6, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
Resolve qax-os#318, add new functions `SetPageLayout` and `GetPageLayout`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants