Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #442 #448

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix #442 #448

merged 1 commit into from
Jul 25, 2019

Conversation

Sustainedhhh
Copy link
Contributor

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri merged commit da7001f into qax-os:master Jul 25, 2019
@xuri
Copy link
Member

xuri commented Jul 25, 2019

LGTM, thanks @Sustainedhhh.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
@xuri
Merge pull request qax-os#448 from Sustainedhhh/master
6774f2c 
Fix qax-os#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sustainedhhh @xuri