Fix row duplicate mechanism #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update forked repository
Add header options to pivot table opts Add Style name options to pivot table opts
Add header options to pivot table opts Add Style name options to pivot table opts
…ovided. (qax-os#708) fix to create pivot table in case there is no input from Columns Co-authored-by: Jin Kim <jinhyuk.kim@cerence.com> Co-authored-by: xuri <xuri.me@gmail.com>
* extend cell value load to support custom datetime format * cleanup incorrect imports * fix numeric values conversion as done in legacy Excel * fix tests coverage * revert temporary package name fix * remove personal info from test XLSX files * remove unused dependencies * update format conversion in parseTime * new UT to increase code coverage * Resolve code review issue for PR qax-os#703 * Rename broken file name generated by unit test Co-authored-by: xuri <xuri.me@gmail.com>
* use io.Copy from stream temp file to zip Writer * fix nil * log * build * delete log * fix compatibility for office * Update go module Co-authored-by: lijingfeng <lijingfeng@laiye.com> Co-authored-by: xuri <xuri.me@gmail.com>
…ith KingSoft WPS - Avoid to create duplicate style - Update unit test for the auto filter - Init code scanning alerts
- Update unit test
… lexer panic on retrieving the top token type
…g worksheet when rename with same names
…ex returned by NewSheet in some case, fix panic on formatted value with no built-in number format ID
* optimize marshal * optimize mem alloc * add benchmark testing * add NewSheetWithRowNum testing * sync struct fields order * add BenchmarkNewSheetWithStreamWriter * delete NewSheetWithRowNum and benchmark test
Add header options to pivot table opts Add Style name options to pivot table opts
# Conflicts: # go.mod # go.sum # sheetpr_test.go
# Conflicts: # go.mod # go.sum
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 31 31
Lines 8571 8571
=======================================
Hits 8290 8290
Misses 160 160
Partials 121 121
Continue to review full report at Codecov.
|
|
LGTM, thanks for your PR. |
xuri
added
the
size/XS
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix row duplication mechanism
Description
When you want to copy row - formulas copied as a reference from the previous row. If you want to change formulas in the current row they also would be changed in the original row.
Motivation and Context
This fix makes a deep copy of the original row to prevent its behavior.
How Has This Been Tested
It was tested manually and using it in my project.
Types of changes
Checklist