Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excelize: support nested calc for if formula #988

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

bailantaotao
Copy link
Contributor

PR Details

Support nested calc for if formula

Description

if formula can be placed with formula, e.q. ROUND

Related Issue

#987

Motivation and Context

it solves the problem for nested formula doesn't calculation

How Has This Been Tested

MAC os 11.5
golang 1.16.6

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #988 (f44fc43) into master (43a057b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          31       31           
  Lines       11085    11096   +11     
=======================================
+ Hits        10806    10817   +11     
  Misses        155      155           
  Partials      124      124           
Flag Coverage Δ
unittests 97.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
calc.go 97.93% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a057b...f44fc43. Read the comment docs.

@xuri xuri merged commit 61d0ed1 into qax-os:master Aug 12, 2021
@xuri
Copy link
Member

xuri commented Aug 12, 2021

LGTM, thanks for your PR.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants