Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument property in proteomics domain is not precise #786

Closed
1 task done
sven1103 opened this issue Aug 15, 2024 · 2 comments · Fixed by #832
Closed
1 task done

Instrument property in proteomics domain is not precise #786

sven1103 opened this issue Aug 15, 2024 · 2 comments · Fixed by #832
Assignees
@KochTobi
Labels
core Feature or fix task considered to be in the core product enhancement New feature or request

Comments

@sven1103
Copy link
Contributor

What are you missing?

For users the property "instrument" when registering measurements is not clear, since it can be the LC system, the mass spec device, or both.

What we actually expect, is the ms device.

Why do you need a solution?

It is unclear for the users what is expected.

Ideas

Maybe just call it MS device, and be precise.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@sven1103 sven1103 added enhancement New feature or request triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 15, 2024
@sven1103
Copy link
Contributor Author

No need to change instrument for NGS (@oquendoM)

@sven1103 sven1103 added core Feature or fix task considered to be in the core product and removed triage An issue that is in discussion to be either scheduled for implepmentation or denied labels Aug 15, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 15, 2024
@KochTobi KochTobi assigned KochTobi and unassigned sven1103 and Shraddha0903 Sep 16, 2024
KochTobi added a commit that referenced this issue Sep 16, 2024
@KochTobi
Adapt proteomics template
265accb 
Fixes the edit case and renames instrument to MS device

fixes #786
@KochTobi KochTobi linked a pull request Sep 16, 2024 that will close this issue
Edit templates for measurement registration #832
Merged
@KochTobi KochTobi mentioned this issue Sep 16, 2024
Merged
@github-actions github-actions bot removed the stale label Sep 17, 2024
KochTobi added a commit that referenced this issue Sep 17, 2024
@KochTobi @Steffengreiner
Edit templates for measurement registration (#832)
f99ebc2 
* WIP

* wip

* make it work

* Extract behaviour

* remove unused method

* Adapt proteomics template

Fixes the edit case and renames instrument to MS device

fixes #786

* Make ngs row creation simpler

Uses the enum and enhanced switch to make sure all columns are covered and removes complexity.

* remove duplicate row creation for ngs

* Rename `Instrument` to `MS Device` in template

* Fix column name

* Fix sheet locking

Excel protected the visible sheet. I do not know why and can only speculate that some reordering was not complete. Creating the hidden sheet second solves the issue.

* replace instrument by ms device for proteomics

* correct spelling

* fix jpa access

* solves #747 add technical replicate

* fix constructors in tests

* use correct methods

* Fix wrong imports

Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de>

* move test

Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de>

* Add QBIC_SAMPLE_ID

Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de>

---------

Co-authored-by: steffengreiner <steffen.greiner@qbic.uni-tuebingen.de>
@KochTobi KochTobi closed this as completed by moving to Done in Sprint Planning Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KochTobi KochTobi

Labels
core Feature or fix task considered to be in the core product enhancement New feature or request
Projects
Sprint Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit templates for measurement registration qbicsoftware/data-manager-app
3 participants
@sven1103 @KochTobi @Shraddha0903